cloud-fan commented on a change in pull request #32602:
URL: https://github.com/apache/spark/pull/32602#discussion_r637977324
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1307,6 +1308,69 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-35455: Enhance EliminateUnnecessaryJoin - single join") {
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
+ Seq(
+ // left semi join and empty left side
+ ("SELECT * FROM (SELECT * FROM testData WHERE value = '0')t1 LEFT SEMI
JOIN " +
+ "testData2 t2 ON t1.key = t2.a", true),
+ // left anti join and empty left side
+ ("SELECT * FROM (SELECT * FROM testData WHERE value = '0')t1 LEFT ANTI
JOIN " +
+ "testData2 t2 ON t1.key = t2.a", true),
+ // left outer join and empty left side
+ ("SELECT * FROM (SELECT * FROM testData WHERE key = 0)t1 LEFT JOIN
testData2 t2 ON " +
+ "t1.key = t2.a", true),
+ // left outer join and non-empty left side
+ ("SELECT * FROM testData t1 LEFT JOIN testData2 t2 ON " +
+ "t1.key = t2.a", false),
+ // right outer join and empty right side
+ ("SELECT * FROM testData t1 RIGHT JOIN (SELECT * FROM testData2 WHERE
b = 0)t2 ON " +
+ "t1.key = t2.a", true),
+ // right outer join and non-empty right side
+ ("SELECT * FROM testData t1 RIGHT JOIN testData2 t2 ON " +
+ "t1.key = t2.a", false),
+ // full outer join and both side empty
+ ("SELECT * FROM (SELECT * FROM testData WHERE key = 0)t1 FULL JOIN " +
+ "(SELECT * FROM testData2 WHERE b = 0)t2 ON t1.key = t2.a", true),
+ // full outer join and left side empty right side non-empty
+ ("SELECT * FROM (SELECT * FROM testData WHERE key = 0)t1 FULL JOIN " +
+ "testData2 t2 ON t1.key = t2.a", true)
+ ).foreach { case (query, isEliminated) =>
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
+ assert(findTopLevelBaseJoin(plan).size == 1)
+ assert(findTopLevelBaseJoin(adaptivePlan).isEmpty == isEliminated,
adaptivePlan)
+ }
+ }
+ }
+
+ test("SPARK-35455: Enhance EliminateUnnecessaryJoin - multi join") {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
