tgravescs commented on a change in pull request #32526:
URL: https://github.com/apache/spark/pull/32526#discussion_r637979574
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -781,20 +782,7 @@ private[spark] class ExecutorAllocationManager(
stageAttemptToNumRunningTask(stageAttempt) -= 1
if (stageAttemptToNumRunningTask(stageAttempt) == 0) {
stageAttemptToNumRunningTask -= stageAttempt
- if (!stageAttemptToNumTasks.contains(stageAttempt)) {
- val rpForStage = resourceProfileIdToStageAttempt.filter { case
(k, v) =>
- v.contains(stageAttempt)
- }.keys
- if (rpForStage.size == 1) {
- // be careful about the removal from here due to late tasks,
make sure stage is
- // really complete and no tasks left
- resourceProfileIdToStageAttempt(rpForStage.head) -=
stageAttempt
- } else {
- logWarning(s"Should have exactly one resource profile for
stage $stageAttempt," +
- s" but have $rpForStage")
- }
- }
-
+ removeStageFromResourceProfileIfUnused(stageAttempt)
Review comment:
oh wait, I think I see it. stageAttemptToNumTasks only gets cleaned up
in the onStageCompleted method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
