cloud-fan commented on a change in pull request #32488:
URL: https://github.com/apache/spark/pull/32488#discussion_r638066500
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala
##########
@@ -89,10 +89,11 @@ import org.apache.spark.sql.types._
*/
object UnwrapCastInBinaryComparison extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan =
plan.transformWithPruning(
- _.containsPattern(BINARY_COMPARISON), ruleId) {
+ _.containsAnyPattern(BINARY_COMPARISON, IN), ruleId) {
Review comment:
You are not supposed to use `Expression` to construct a query directly,
as it's a private API and you will be at your own risk. `InSet` can only be
optimized from `In`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
