otterc commented on a change in pull request #32007:
URL: https://github.com/apache/spark/pull/32007#discussion_r638106460
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -761,28 +818,31 @@ public boolean equals(Object o) {
if (o == null || getClass() != o.getClass()) {
return false;
}
- AppShuffleId that = (AppShuffleId) o;
- return shuffleId == that.shuffleId && Objects.equal(appId, that.appId);
+ AppAttemptShuffleId that = (AppAttemptShuffleId) o;
+ return Objects.equal(appId, that.appId)
+ && attemptId == that.attemptId
+ && shuffleId == that.shuffleId;
}
@Override
public int hashCode() {
- return Objects.hashCode(appId, shuffleId);
+ return Objects.hashCode(appId, attemptId, shuffleId);
}
@Override
public String toString() {
- return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
- .append("appId", appId)
- .append("shuffleId", shuffleId)
+ return Objects.toStringHelper(this)
+ .add("appId", appId)
+ .add("attemptId", attemptId)
+ .add("shuffleId", shuffleId)
.toString();
}
}
/** Metadata tracked for an actively merged shuffle partition */
- public static class AppShufflePartitionInfo {
+ public static class AppAttemptShufflePartitionInfo {
Review comment:
We only create a partition info for the latest attempt. I don't really
think renaming this class is necessary.
The java doc also says this. Here `attempt` has no significance since it is
just the part of the `AppAttemptShuffleId` which is already renamed. This just
makes the class name longer and adds bunch of other changes which just because
of this change in name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
