ueshin commented on a change in pull request #32611:
URL: https://github.com/apache/spark/pull/32611#discussion_r638307070
##########
File path: python/pyspark/pandas/data_type_ops/num_ops.py
##########
@@ -40,16 +40,19 @@
from pyspark.pandas.series import Series # noqa: F401 (SPARK-34943)
-def is_valid_operand_for_numeric_arithmetic(operand: Any) -> bool:
+def is_valid_operand_for_numeric_arithmetic(
+ operand: Any,
+ allow_bool_index_ops: bool = True
+) -> bool:
Review comment:
Shall we make `allow_bool_index_ops` a keyword-only argument?
```py
def is_valid_operand_for_numeric_arithmetic(
operand: Any,
*,
allow_bool_index_ops: bool = True
) -> bool:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
