xinrong-databricks commented on a change in pull request #32626: URL: https://github.com/apache/spark/pull/32626#discussion_r638336697
########## File path: python/pyspark/pandas/data_type_ops/complex_ops.py ########## @@ -0,0 +1,74 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import TYPE_CHECKING, Union + +from pyspark.pandas.base import column_op, IndexOpsMixin +from pyspark.pandas.data_type_ops.base import DataTypeOps +from pyspark.sql import functions as F +from pyspark.sql.types import ArrayType, NumericType + +if TYPE_CHECKING: + from pyspark.pandas.indexes import Index # noqa: F401 (SPARK-34943) + from pyspark.pandas.series import Series # noqa: F401 (SPARK-34943) + + +class ArrayOps(DataTypeOps): + """ + The class for binary operations of pandas-on-Spark objects with ArrayType. + """ + + @property + def pretty_name(self) -> str: + return 'arrays' + + def add(self, left, right) -> Union["Series", "Index"]: + if not isinstance(right, IndexOpsMixin) or ( + isinstance(right, IndexOpsMixin) and not isinstance(right.spark.data_type, ArrayType) + ): + raise TypeError( + "Concatenation can not be applied to %s and the given type." % self.pretty_name) + + left_type = left.spark.data_type.elementType + right_type = right.spark.data_type.elementType + + if left_type != right_type and not ( + isinstance(left_type, NumericType) and isinstance(right_type, NumericType)): + raise TypeError( + "Concatenation can only be applied to %s of the same type" % self.pretty_name) + + return column_op(F.concat)(left, right) + + +class MapOps(DataTypeOps): + """ + The class for binary operations of pandas-on-Spark objects with MapType. + """ + + @property + def pretty_name(self) -> str: + return 'PySpark MapType' Review comment: Does the name look good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
