ueshin commented on a change in pull request #32649:
URL: https://github.com/apache/spark/pull/32649#discussion_r638354030
##########
File path: python/pyspark/pandas/tests/plot/test_frame_plot_plotly.py
##########
@@ -39,7 +39,8 @@
@unittest.skipIf(
not have_plotly or LooseVersion(pd.__version__) < "1.0.0",
- plotly_requirement_message + " Or pandas<1.0; pandas<1.0 does not support
latest plotly "
+ ("" if plotly_requirement_message is None else "%s or " %
plotly_requirement_message) +
+ "pandas<1.0; pandas<1.0 does not support latest plotly "
"and/or 'plotting.backend' option.",
)
Review comment:
How about separating the `skipIf`?
```py
@unittest.skipIf(not have_plotly, plotly_requirement_message)
@unittest.skipIf(
LooseVersion(pd.__version__) < "1.0.0",
"pandas<1.0; pandas<1.0 does not support latest plotly and/or
'plotting.backend' option.",
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
