Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5823#discussion_r29487432
  
    --- Diff: 
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
 ---
    @@ -168,6 +170,26 @@ private[spark] object CoarseGrainedExecutorBackend 
extends Logging {
               driverConf.set(key, value)
             }
           }
    +      // Delegation Token Updater is not supported in Hadoop 1, so use 
reflection.
    +      // Can't use Option[ExecutorDelegationTokenUpdater] because it is 
built only in YARN
    +      // profile, so use Option[Any] since even the stop method call will 
be via reflection.
    +      var tokenUpdaterOption: Option[Any] = None
    +      var tokenUpdaterClass: Option[Class[_]] = None
    --- End diff --
    
    I didn't want to add more methods to `SparkHadoopUtil` and 
`YarnSparkHadoopUtil`, but since that gets rid of the reflection and also 
guarantees that `addCredentials` gets called only in YARN mode, I guess it is 
worth it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to