viirya commented on pull request #32136:
URL: https://github.com/apache/spark/pull/32136#issuecomment-847649737


   > Which check are you referring to?
   
   There is assertion that dynamic allocation should be enabled under 
stage-level scheduling. I mean if we remove such assertion, will it affect 
normal cases of stage-level scheduling?
   
   > @tgravescs yes the target might be archieved directly with the mapping. 
But I think that's would be the last choice as the community wants to introduce 
less invading changes when working across the modules. And that's the reason 
that @viirya proposed plugin APIs first and we're now discussing the 
possibility of reusing existing feature - stage level scheduling.
   But if we still have to introduce many invading changes (e.g., the mapping) 
even if reusing the stage level scheduling, I think we should revisit our 
decision.
   
   That's correct as this is one major point behind this API. It is proposed to 
keep as separate as possible to not affect Spark other than SS code path. 
Personally I'd refer a separate design. You may know more about how much 
invading change we need to support the use-case in stage-level scheduling. Let 
me know if you need to revisit the decision so I can follow up with the 
direction. I'll be willing to continue on this API or turn to stage-level 
scheduling with some changes if you think it is better.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to