som-snytt commented on a change in pull request #32648:
URL: https://github.com/apache/spark/pull/32648#discussion_r638564182
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -81,6 +81,7 @@ class Iso8601DateFormatter(
try {
formatter
} catch checkLegacyFormatter(pattern,
legacyFormatter.validatePatternString)
+ ()
Review comment:
This aligns with Scala 3. I guess the `Unit` here comes from the method
result type. I'll ask whether that is desirable; arguably it could insert the
parens automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
