copperybean commented on a change in pull request #32645:
URL: https://github.com/apache/spark/pull/32645#discussion_r638890380
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -527,6 +527,7 @@ object FunctionRegistry {
expression[MakeDate]("make_date"),
expression[MakeTimestamp]("make_timestamp"),
expression[MakeInterval]("make_interval"),
+ expression[MakeYMInterval]("make_ym_interval"),
Review comment:
I think the name of interval series functions should be like following:
```
make_interval
make_duration
make_period
```
This naming convention has been adopted by Java such as
[Duration](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/time/Duration.html)
and
[Period](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/time/Period.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
