attilapiros commented on a change in pull request #32114:
URL: https://github.com/apache/spark/pull/32114#discussion_r639207240
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -422,7 +430,7 @@ class BlockManagerMasterEndpoint(
val locations = blockLocations.get(blockId)
if (locations != null) {
locations.foreach { blockManagerId: BlockManagerId =>
- val blockManager = blockManagerInfo.get(blockManagerId)
+ val blockManager =
blockManagerInfo.get(blockManagerId).filter(_.isAlive)
Review comment:
What about introducing some helper methods?
Sth like:
```scala
private def aliveBlockManagerInfo(bmId: BlockManagerId):
Option[BlockManagerInfo] =
blockManagerInfo.get(bmId).filter(_.isAlive)
private def allAliveBlockManagerInfos() =
blockManagerInfo.values.filter(_.isAlive)
```
They even could be inline methods...
@Ngone51 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
