allisonwang-db commented on a change in pull request #32303:
URL: https://github.com/apache/spark/pull/32303#discussion_r639383358
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1607,33 +1622,30 @@ class Analyzer(override val catalogManager:
CatalogManager)
}
}
f1.copy(arguments = f1.arguments.flatMap {
- case s: Star => s.expand(child, resolver)
+ case s: Star => expand(s)
case o => o :: Nil
})
case c: CreateNamedStruct if containsStar(c.valExprs) =>
val newChildren = c.children.grouped(2).flatMap {
- case Seq(k, s : Star) => CreateStruct(s.expand(child,
resolver)).children
+ case Seq(k, s : Star) => CreateStruct(expand(s)).children
case kv => kv
}
c.copy(children = newChildren.toList )
case c: CreateArray if containsStar(c.children) =>
c.copy(children = c.children.flatMap {
- case s: Star => s.expand(child, resolver)
+ case s: Star => expand(s)
case o => o :: Nil
})
case p: Murmur3Hash if containsStar(p.children) =>
p.copy(children = p.children.flatMap {
- case s: Star => s.expand(child, resolver)
+ case s: Star => expand(s)
case o => o :: Nil
})
case p: XxHash64 if containsStar(p.children) =>
p.copy(children = p.children.flatMap {
- case s: Star => s.expand(child, resolver)
+ case s: Star => expand(s)
case o => o :: Nil
})
- // count(*) has been replaced by count(1)
- case o if containsStar(o.children) =>
- throw QueryCompilationErrors.invalidStarUsageError(s"expression
'${o.prettyName}'")
Review comment:
Yes it was moved to CheckAnalysis because the star expression might be
resolved using outer plan references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
