cloud-fan commented on a change in pull request #32364:
URL: https://github.com/apache/spark/pull/32364#discussion_r639396667



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -48,7 +48,7 @@ import org.apache.spark.sql.util.{CaseInsensitiveStringMap, 
PartitioningUtils}
 import org.apache.spark.util.Utils
 
 object SessionCatalog {
-  val DEFAULT_DATABASE = "default"
+  val DEFAULT_DATABASE = SQLConf.get.defaultDatabase

Review comment:
       This makes it look like it's a runtime config. Let's write 
`getConf(StaticSQLConf.CATALOG_DEFAULT_DATABASE)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to