viirya commented on a change in pull request #32667:
URL: https://github.com/apache/spark/pull/32667#discussion_r639465528
##########
File path: python/pyspark/rdd.py
##########
@@ -2067,7 +2067,7 @@ def add_shuffle_key(split, iterator):
avg = int(size / n) >> 20
# let 1M < avg < 10M
if avg < 1:
- batch *= 1.5
Review comment:
Hm..I thought increasing `batch` is for `c > batch`. In other words, it
increases the size of batch if it reaches the current batch size, but used
memory is still under `limit` (and the average size of bucket is small).
If it reaches memory limit before reaching the batch size (so it means
current batch size is more than memory limit), it seems not make sense to
increase batch size (even the average size of bucket is small).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
