Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3913#issuecomment-98039213
Hey @sryza and @srowen, sorry to vacillate here, but after looking at this
more I really do think it would be better to just make this a static method on
`SparkContext`. The reason is the following:
1. For users, it's much nicer to just call `SparkContext.estimateSize()`
since in may cases they've already imported SparkContext. Having them import
some other class for this one static function seems a little strange.
2. For developers, we now have this whole class exposed and a lot more room
to accidentally expose new functionally if this class is later changed. There
is a single static function buried deep in the middle of the class description
that is public.
Basically I don't see a big motivation for having a separate class for
this, and it forces us to make some longer term commitment to that class name,
having static utility classes in the top level namespace, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
