c21 commented on a change in pull request #32547:
URL: https://github.com/apache/spark/pull/32547#discussion_r639940755
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
##########
@@ -680,13 +680,36 @@ case class SortMergeJoinExec(
ctx.currentVars = streamedVars ++ bufferedVars
val cond = BindReferences.bindReference(
condition.get, streamedPlan.output ++ bufferedPlan.output).genCode(ctx)
- // evaluate the columns those used by condition before loop
+ // Evaluate the columns those used by condition before loop
val before =
s"""
|boolean $loaded = false;
|$streamedBefore
""".stripMargin
+ val loadStreamed =
+ s"""
+ |if (!$loaded) {
+ | $loaded = true;
+ | $streamedAfter
+ |}
+ """.stripMargin
Review comment:
`loadStreamed` is not used by `LeftAnti`.
I think you are referring to `boolean $loaded = false;` in `before` should
not be needed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
