mridulm commented on a change in pull request #32114:
URL: https://github.com/apache/spark/pull/32114#discussion_r640273239
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -422,7 +430,7 @@ class BlockManagerMasterEndpoint(
val locations = blockLocations.get(blockId)
if (locations != null) {
locations.foreach { blockManagerId: BlockManagerId =>
- val blockManager = blockManagerInfo.get(blockManagerId)
+ val blockManager =
blockManagerInfo.get(blockManagerId).filter(_.isAlive)
Review comment:
I am slightly more in favor of @attilapiros's suggestion .. I am more
concerned with future evolution, where someone might accidentally forget to
check for `isAlive` : the helper methods should defend against that.
I am fine with either approach though - in current state and with this
enhancement, I am fine with this going through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
