sumeetgajjar edited a comment on pull request #32114: URL: https://github.com/apache/spark/pull/32114#issuecomment-849372854
> https://github.com/apache/spark/blob/5cc17ba0c7d81278a622fb474cf18f8e8530335f/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala#L116 > > @sumeetgajjar ^^^ Shall we not reply when it's already an inactive BlockManager here? It would avoid the network timeout issue when the executor is shut down. @Ngone51 I don't follow, how can we not reply to `RegisterBlockManager` when it expects a return type of `BlockManagerId`. Can you please elaborate on this? Please correct me if I am missing something here. https://github.com/apache/spark/blob/5cc17ba0c7d81278a622fb474cf18f8e8530335f/core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala#L77-L80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
