cloud-fan commented on a change in pull request #32685:
URL: https://github.com/apache/spark/pull/32685#discussion_r640349229
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -251,8 +251,7 @@ object OptimizeSkewedJoin extends CustomShuffleReaderRule {
case shj @ ShuffledHashJoinExec(_, _, joinType, _, _,
ShuffleStage(left: ShuffleQueryStageExec),
- ShuffleStage(right: ShuffleQueryStageExec), isSkewJoin)
- if !isSkewJoin && supportedJoinTypes.contains(joinType) =>
Review comment:
We don't need to check the join types now, as `tryOptimizeJoinChildren`
will return None immediately if the join type is not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
