cloud-fan commented on a change in pull request #32563:
URL: https://github.com/apache/spark/pull/32563#discussion_r640447743
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##########
@@ -65,6 +65,15 @@ object HiveResult {
// database, table name, isTemp.
case command @ ExecutedCommandExec(s: ShowTablesCommand) if !s.isExtended
=>
command.executeCollect().map(_.getString(1))
+ // SHOW TABLE EXTENDED in Hive only output the information column.
+ case command @ ExecutedCommandExec(s: ShowTablesCommand) if s.isExtended =>
+ if (s.conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
Review comment:
nit: I think it's more robust to check the data type of `s.output(3)`
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -830,6 +830,8 @@ case class ShowTablesCommand(
isExtended: Boolean = false,
partitionSpec: Option[TablePartitionSpec] = None) extends
LeafRunnableCommand {
+ private val keepLegacySchema =
conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
