huaxingao commented on a change in pull request #32049:
URL: https://github.com/apache/spark/pull/32049#discussion_r641304562



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -673,6 +677,25 @@ object DataSourceStrategy
     (nonconvertiblePredicates ++ unhandledPredicates, pushedFilters, 
handledFilters)
   }
 
+  protected[sql] def translateAggregate(
+      aggregates: AggregateExpression,
+      pushableColumn: PushableColumnBase): Option[Seq[AggregateFunc]] = {
+    aggregates.aggregateFunction match {
+      case [email protected](pushableColumn(name)) =>

Review comment:
       Parquet statistics doesn't have the right Max/Min for nested column. For 
example, for this
   ```
   +--------------+
   |            _1|
   +--------------+
   |  {6, [val_6]}|
   |  {7, [val_7]}|
   |  {8, [val_8]}|
   |  {9, [val_9]}|
   |{10, [val_10]}|
   ```
   It has Max 10 and Min 6. I don't push down Max/Min for nested columns, only 
push down Count for nested. I added a simple test for Count nested column.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to