viirya commented on pull request #32699: URL: https://github.com/apache/spark/pull/32699#issuecomment-850765540
> this builds upon/relies upon the common expressions being sorted from your previous MR right? Yes, if you're asking if this is built on previous PR that sorts subexpressions. > And theoretically if #32559 hadn't been fixed, this would sort of address that issue by creating a subexpression function for each level that builds on the previous instead of starting from scratch? Yea, if #32559 is not fixed, this could somehow relieve that but it still suffers from redundant subexpression call if it is split case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
