Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/648#discussion_r12301802
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockId.scala ---
    @@ -19,14 +19,18 @@ package org.apache.spark.storage
     
     import java.util.UUID
     
    +import org.apache.spark.annotation.DeveloperApi
    +
     /**
    + * :: DeveloperApi ::
      * Identifies a particular Block of data, usually associated with a single 
file.
      * A Block can be uniquely identified by its filename, but each type of 
Block has a different
      * set of keys which produce its unique name.
      *
      * If your BlockId should be serializable, be sure to add it to the 
BlockId.apply() method.
      */
    -private[spark] sealed abstract class BlockId {
    +@DeveloperApi
    +sealed abstract class BlockId {
    --- End diff --
    
    Maybe it makes sense to give users some more semantics about this... it 
might be good to leave it as is


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to