SaurabhChawla100 commented on a change in pull request #32558:
URL: https://github.com/apache/spark/pull/32558#discussion_r642258661
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -68,6 +68,8 @@ private[sql] class JSONOptions(
parameters.get("allowNonNumericNumbers").map(_.toBoolean).getOrElse(true)
val allowBackslashEscapingAnyCharacter =
parameters.get("allowBackslashEscapingAnyCharacter").map(_.toBoolean).getOrElse(false)
+ val allowDateFormat =
+ parameters.get("allowDateFormat").map(_.toBoolean).getOrElse(false)
Review comment:
**Shall we add this option into CSV too? I would name it like
inferDateType.** - Added for CSV also and change the name to inferDateType
**BTW, I am just curious. Why did you disable it specifically here in
JSON?** - This is to keep in sync with older version of spark, If someone wants
to use the dateType, they can enable it in the option. This is just to prevent
any migration issue to spark-3.2.0 from the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]