yaooqinn commented on a change in pull request #32708:
URL: https://github.com/apache/spark/pull/32708#discussion_r642306212
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -45,10 +45,15 @@ private[spark] class BasicExecutorFeatureStep(
private val blockManagerPort = kubernetesConf
.sparkConf
.getInt(BLOCK_MANAGER_PORT.key, DEFAULT_BLOCKMANAGER_PORT)
+ private val hostNetwork = kubernetesConf.get(KUBERNETES_EXECUTOR_HOSTNETWORK)
require(blockManagerPort == 0 || (1024 <= blockManagerPort &&
blockManagerPort < 65536),
"port number must be 0 or in [1024, 65535]")
+ if (hostNetwork) {
+ require(blockManagerPort == 0, "when enable hostNetwork executor port
should be random")
Review comment:
we also need to cover this line in test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
