gengliangwang commented on a change in pull request #32725:
URL: https://github.com/apache/spark/pull/32725#discussion_r642828871
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1605,7 +1605,7 @@ class AdaptiveQueryExecSuite
}
test("SPARK-33933: Materialize BroadcastQueryStage first in AQE") {
- val testAppender = new LogAppender("aqe query stage materialization order
test")
+ val testAppender = new LogAppender("aqe query stage materialization order
test", 10000)
Review comment:
I try running this locally, the log size is 388.
```
loggerName.map(Logger.getLogger).getOrElse(Logger.getRootLogger)
```
The test is flaky since it is using `Logger.getRootLogger`.
Shall we increase the default limit of LogAppender instead? What was the
reason for adding a limit in the LogAppender?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
