cloud-fan commented on a change in pull request #32724:
URL: https://github.com/apache/spark/pull/32724#discussion_r642840787



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEOptimizer.scala
##########
@@ -63,3 +70,8 @@ class AQEOptimizer(conf: SQLConf) extends 
RuleExecutor[LogicalPlan] {
       LogicalPlanIntegrity.checkIfExprIdsAreGloballyUnique(plan))
   }
 }
+
+/**
+ * ConvertToLocalRelation at AQE optimizer side.
+ */
+object AQEConvertToLocalRelation extends ConvertToLocalRelationBase

Review comment:
       If that's the goal I think we should update the tracking system to 
measure the effectiveness of AQE optimizer rules separately.
   
   It's super annoying to do this again and again for every normal optimizer 
rule we add to AQE. e.g. why don't we do it for `UpdateAttributeNullability`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to