srowen commented on a change in pull request #32725:
URL: https://github.com/apache/spark/pull/32725#discussion_r643101102
##########
File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala
##########
@@ -217,19 +217,27 @@ abstract class SparkFunSuite
*/
protected def withLogAppender(
appender: Appender,
- loggerName: Option[String] = None,
+ loggerNames: Seq[String] = Seq.empty,
level: Option[Level] = None)(
f: => Unit): Unit = {
- val logger =
loggerName.map(Logger.getLogger).getOrElse(Logger.getRootLogger)
- val restoreLevel = logger.getLevel
- logger.addAppender(appender)
- if (level.isDefined) {
- logger.setLevel(level.get)
+ val loggers = if (loggerNames.nonEmpty) {
+ loggerNames.map(Logger.getLogger)
+ } else {
+ Seq(Logger.getRootLogger)
+ }
+ val restoreLevels = loggers.map(_.getLevel)
+ loggers.foreach { logger =>
+ logger.addAppender(appender)
+ if (level.isDefined) {
Review comment:
This could be `level.foreach` in both places, but doesn't matter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
