srowen commented on a change in pull request #32717:
URL: https://github.com/apache/spark/pull/32717#discussion_r643111820
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
##########
@@ -225,10 +231,31 @@ case class CachedRDDBuilder(
_cachedColumnBuffers
}
+ def manualClose[T <: CachedBatch](entry: T): T = {
+ val entryManualCloseTasks = Future {
+ entry match {
+ case o: AutoCloseable =>
+ try {
+ o.close
Review comment:
We can't reuse the manualClose method defined in your previous PR?
I'm also not seeing that CachedBatch implementations have any resources to
free - what are you looking at there?
In this case, maybe we don't want to even create the Future unless there is
something AutoCloseable to close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
