cloud-fan commented on a change in pull request #32534:
URL: https://github.com/apache/spark/pull/32534#discussion_r643125416
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -385,9 +390,33 @@ private[spark] class MemoryStore(
}
}
+ def manualClose[T <: MemoryEntry[_]](entry: T): T = {
+ val entryManualCloseTasks = Future {
+ entry match {
+ case e: DeserializedMemoryEntry[_] => e.value.foreach {
+ case o: AutoCloseable =>
+ try {
+ o.close
+ } catch {
+ case NonFatal(e) =>
+ logWarning(s"Got NonFatal exception during remove")
+ }
+ case _ =>
+ }
+ case _ =>
+ }
+ }
+ entryManualCloseTasks.onComplete {
+ case Success(_) =>
+ case Failure(e) => throw e
Review comment:
To confirm: this is a callback, so throwing an exception doesn't break
the Spark application and just gets logged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
