xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r643241601
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
##########
@@ -78,7 +82,32 @@ public static void collectMetric(
new ShuffleServiceMetricsInfo(name + "_rate1", "1 minute rate of
timer " + name),
t.getOneMinuteRate())
.addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean rate
of timer " + name),
- t.getMeanRate());
+ t.getMeanRate())
+ .addGauge(
+ getShuffleServiceMetricsInfoForGenericValue(timingName, "max"),
snapshot.getMax())
+ .addGauge(
+ getShuffleServiceMetricsInfoForGenericValue(timingName, "min"),
snapshot.getMin())
+ .addGauge(
+ getShuffleServiceMetricsInfoForGenericValue(timingName, "mean"),
snapshot.getMean())
+ .addGauge(
+ getShuffleServiceMetricsInfoForGenericValue(timingName, "stdDev"),
snapshot.getStdDev());
+ for (int percentileThousands : new int[] { 10, 50, 250, 500, 750, 950,
980, 990, 999 }) {
+ String percentileStr;
+ switch (percentileThousands) {
+ case 10:
+ percentileStr = "1stPercentile";
+ break;
+ case 999:
+ percentileStr = "99.9thPercentile";
Review comment:
Thanks for sharing, I did not realize there was an existing convention
here. I've updated it to be `999thPercentile`. I didn't borrow it from anywhere
in particular, just how I would say it aloud: "ninety-nine point ninth
percentile".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
