Github user kanzhang commented on the pull request:

    https://github.com/apache/spark/pull/448#issuecomment-42248502
  
    @marmbrus my untrained eyes couldn't spot any difference (you may want to 
verify it yourself just to make sure :). For example,
    
    RDD.unpersist() with RDD[T] return type:
    ```
      public org.apache.spark.rdd.RDD<T> unpersist(boolean);
        flags: ACC_PUBLIC
        Code:
          stack=4, locals=2, args_size=2
             0: aload_0       
             1: new           #208                // class 
org/apache/spark/rdd/RDD$$anonfun$unpersist$1
             4: dup           
             5: aload_0       
             6: invokespecial #209                // Method 
org/apache/spark/rdd/RDD$$anonfun$unpersist$1."<init>":(Lorg/apache/spark/rdd/RDD;)V
             9: invokevirtual #211                // Method 
logInfo:(Lscala/Function0;)V
            12: aload_0       
            13: invokespecial #108                // Method 
sc:()Lorg/apache/spark/SparkContext;
            16: aload_0       
            17: invokevirtual #213                // Method id:()I
            20: iload_1       
            21: invokevirtual #217                // Method 
org/apache/spark/SparkContext.unpersistRDD:(IZ)V
            24: aload_0       
            25: getstatic     #157                // Field 
org/apache/spark/storage/StorageLevel$.MODULE$:Lorg/apache/spark/storage/StorageLevel$;
            28: invokevirtual #160                // Method 
org/apache/spark/storage/StorageLevel$.NONE:()Lorg/apache/spark/storage/StorageLevel;
            31: invokespecial #186                // Method 
storageLevel_$eq:(Lorg/apache/spark/storage/StorageLevel;)V
            34: aload_0       
            35: areturn       
          LocalVariableTable:
            Start  Length  Slot  Name   Signature
                   0      36     0  this   Lorg/apache/spark/rdd/RDD;
                   0      36     1 blocking   Z
          LineNumberTable:
            line 167: 0
            line 168: 12
            line 169: 24
            line 170: 34
        Signature: #1819                        // 
(Z)Lorg/apache/spark/rdd/RDD<TT;>;
    
      public boolean unpersist$default$1();
        flags: ACC_PUBLIC
        Code:
          stack=1, locals=1, args_size=1
             0: iconst_1      
             1: ireturn       
          LocalVariableTable:
            Start  Length  Slot  Name   Signature
                   0       2     0  this   Lorg/apache/spark/rdd/RDD;
          LineNumberTable:
            line 166: 0
    ```
    
    RDD.unpersist() with this.type return type:
    ```
      public org.apache.spark.rdd.RDD<T> unpersist(boolean);
        flags: ACC_PUBLIC
        Code:
          stack=4, locals=2, args_size=2
             0: aload_0       
             1: new           #208                // class 
org/apache/spark/rdd/RDD$$anonfun$unpersist$1
             4: dup           
             5: aload_0       
             6: invokespecial #209                // Method 
org/apache/spark/rdd/RDD$$anonfun$unpersist$1."<init>":(Lorg/apache/spark/rdd/RDD;)V
             9: invokevirtual #211                // Method 
logInfo:(Lscala/Function0;)V
            12: aload_0       
            13: invokespecial #108                // Method 
sc:()Lorg/apache/spark/SparkContext;
            16: aload_0       
            17: invokevirtual #213                // Method id:()I
            20: iload_1       
            21: invokevirtual #217                // Method 
org/apache/spark/SparkContext.unpersistRDD:(IZ)V
            24: aload_0       
            25: getstatic     #157                // Field 
org/apache/spark/storage/StorageLevel$.MODULE$:Lorg/apache/spark/storage/StorageLevel$;
            28: invokevirtual #160                // Method 
org/apache/spark/storage/StorageLevel$.NONE:()Lorg/apache/spark/storage/StorageLevel;
            31: invokespecial #186                // Method 
storageLevel_$eq:(Lorg/apache/spark/storage/StorageLevel;)V
            34: aload_0       
            35: areturn       
          LocalVariableTable:
            Start  Length  Slot  Name   Signature
                   0      36     0  this   Lorg/apache/spark/rdd/RDD;
                   0      36     1 blocking   Z
          LineNumberTable:
            line 172: 0
            line 173: 12
            line 174: 24
            line 175: 34
        Signature: #1705                        // 
(Z)Lorg/apache/spark/rdd/RDD<TT;>;
    
      public boolean unpersist$default$1();
        flags: ACC_PUBLIC
        Code:
          stack=1, locals=1, args_size=1
             0: iconst_1      
             1: ireturn       
          LocalVariableTable:
            Start  Length  Slot  Name   Signature
                   0       2     0  this   Lorg/apache/spark/rdd/RDD;
          LineNumberTable:
            line 171: 0
    ```
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to