xinrong-databricks commented on a change in pull request #32592:
URL: https://github.com/apache/spark/pull/32592#discussion_r643542210
##########
File path: python/pyspark/pandas/data_type_ops/base.py
##########
@@ -87,7 +92,6 @@ def __init__(self, dtype: Dtype, spark_type: DataType):
self.spark_type = spark_type
@property
- @abstractmethod
Review comment:
`@abstractmethod` is removed in order to pass mypy checks.
Otherwise,
```
mypy checks failed:
python/pyspark/pandas/internal.py:1050: error: Cannot instantiate abstract
class 'DataTypeOps' with abstract attribute 'pretty_name'
python/pyspark/pandas/internal.py:1441: error: Cannot instantiate abstract
class 'DataTypeOps' with abstract attribute 'pretty_name'
```
Reference mypy issue: https://github.com/python/mypy/issues/1843.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
