cloud-fan commented on pull request #32743: URL: https://github.com/apache/spark/pull/32743#issuecomment-852856447
IIUC, In the real world this feature is for user-defined off-heap-hashRelation for BHJ, and releasing the memory should be fast, at least should be on-par with releasing `SerializedMemoryEntry` by Spark itself. I think it's fine to follow `SerializedMemoryEntry` and release the `AutoCloseable` in the current thread. If it does introduce perf problems, the Spark vendor that leverages this feature should provide some metrics and propose to release memory entry asynchronously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
