Github user preeze commented on a diff in the pull request:
https://github.com/apache/spark/pull/5835#discussion_r29495922
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -169,7 +160,7 @@ private[spark] object ClosureCleaner extends Logging {
private def instantiateClass(cls: Class[_], outer: AnyRef,
inInterpreter: Boolean): AnyRef = {
// logInfo("Creating a " + cls + " with outer = " + outer)
- if (!inInterpreter) {
+ if (inInterpreter) {
--- End diff --
I guess I see what you mean, @srowen.
The selected if-branch in
`org.apache.spark.util.ClosureCleaner#instantiateClass` in case of seeing an
exception in `org.apache.spark.util.Utils#isInInterpreter` will remain the same
as before but it will be inverted for other situations.
Now I am not sure what's more correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
