Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/622#discussion_r12304123
--- Diff:
core/src/main/scala/org/apache/spark/util/UncaughtExceptionHandler.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.util
+
+import org.apache.spark.executor.ExecutorExitCode
+import org.apache.spark.Logging
+
+object UncaughtExceptionHandler extends Thread.UncaughtExceptionHandler
with Logging {
+ override def uncaughtException(thread: Thread, exception: Throwable) {
+ try {
+ logError("Uncaught exception in thread " + thread, exception)
+
+ // We may have been called from a shutdown hook. If so, we must not
call System.exit().
+ // (If we do, we will deadlock.)
+ if (!Utils.inShutdown()) {
+ if (exception.isInstanceOf[OutOfMemoryError]) {
+ System.exit(ExecutorExitCode.OOM)
+ } else {
+ System.exit(ExecutorExitCode.UNCAUGHT_EXCEPTION)
+ }
+ }
+ } catch {
+ case oom: OutOfMemoryError =>
Runtime.getRuntime.halt(ExecutorExitCode.OOM)
--- End diff --
Honestly, I didn't look too closely at what the existing default uncaught
exception handler was doing. I just moved it over from Executor.scala into
someplace accessible from the scheduled functions. That may not be what we
want; and even if it is what we want, we need to decide just how accessible
UncaughtExceptionHandler needs to be -- almost certainly not fully public like
it is now in this PR.
This handling of OOM has been in Executor's default uncaught exception
handler for a long time, and probably @mateiz can say what the design intention
was.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
