HyukjinKwon commented on a change in pull request #32768:
URL: https://github.com/apache/spark/pull/32768#discussion_r645264640



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -265,6 +265,9 @@ class SessionCatalog(
     if (dbName == DEFAULT_DATABASE) {
       throw QueryCompilationErrors.cannotDropDefaultDatabaseError
     }
+    if (!ignoreIfNotExists) {
+      requireDbExists(dbName)

Review comment:
       `externalCatalog` can be not only Hive but can be other implementations, 
and maybe there could be some special handling for these cases (e.g., cleaning 
up resources)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to