c21 commented on pull request #32210: URL: https://github.com/apache/spark/pull/32210#issuecomment-854386528
> Is 3.1 + 3.2 correct? Let's say, if the build side have two rows r1 and r2, with identical values on join key columns. r1 is processed before OOM and inserted into the in memory hash table, while r2 is processed after the OOM. Now a probe side row p, with the same join key column values can only match r1. p should match r2 as well for correctness. @sigmod - yes you are right. Sorry for missing it. Updated above. For non-semi join, we need to put the rows from stream side to sorter anyway, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
