attilapiros commented on a change in pull request #32727:
URL: https://github.com/apache/spark/pull/32727#discussion_r644442007



##########
File path: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
##########
@@ -1987,6 +1992,10 @@ class BlockManagerSuite extends SparkFunSuite with 
Matchers with BeforeAndAfterE
     }
   }
 
+  test("SPARK-35589: test migration of index-only shuffle blocks during 
decommissioning") {
+    testShuffleBlockDecommissioning(None, true)

Review comment:
       As I see the test body here is the same as the one below ("test 
migration of shuffle blocks during decommissioning - no limit") so are we 
calling `testShuffleBlockDecommissioning(None, true)` twice with just a 
different test name. Is not it?
   
   If I am right then we should come up with a common name for those two tests 
and keep only one with the new name as testing is already takes considerable 
time and we should avoid duplicating the same tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to