dongjoon-hyun commented on a change in pull request #32751:
URL: https://github.com/apache/spark/pull/32751#discussion_r644371254
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
##########
@@ -314,6 +314,7 @@ private[orc] object OrcFileFormat extends HiveInspectors
with Logging {
"NONE" -> "",
"SNAPPY" -> ".snappy",
"ZLIB" -> ".zlib",
+ "LZ4" -> ".lz4",
Review comment:
+1 for @viirya 's suggestion.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
##########
@@ -314,6 +314,7 @@ private[orc] object OrcFileFormat extends HiveInspectors
with Logging {
"NONE" -> "",
"SNAPPY" -> ".snappy",
"ZLIB" -> ".zlib",
+ "LZ4" -> ".lz4",
Review comment:
Please add it to `HiveOrcSourceSuite.scala`.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -649,4 +649,14 @@ class OrcSourceSuite extends OrcSuite with
SharedSparkSession {
checkAnswer(spark.sql("SELECT _col0, _col2.c1 FROM t1"), Seq(Row(1,
"a")))
}
}
+
+ test("SPARK-35612: Support LZ4 compression in ORC data source") {
Review comment:
Could you move this from `OrcSourceSuite` to `OrcSuite`? Then,
`HiveOrcSourceSuite` will test it automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
