Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/5817#discussion_r29508843
--- Diff: dev/run-tests-jenkins ---
@@ -171,15 +171,14 @@ for t in "${PR_TESTS[@]}"; do
# Ensure the test can be found and is a file
if [ -f "${this_test}" ]; then
echo "Running test: $t"
- this_mssg="$(bash "${this_test}" "${ghprbActualCommit}" "${sha1}"
"${current_pr_head}")"
- # Check if this is the merge test as we submit that note *before* and
*after*
- # the tests run
- [ "$t" == "pr_merge_ability" ] && merge_note="${this_mssg}"
+ this_mssg="$(bash "${this_test}" "${ghprbActualCommit}" "${sha1}"
"${current_pr_head}" "2> /dev/null")"
+
pr_message="${pr_message}\n${this_mssg}"
# Ensure, after each test, that we're back on the current PR
git checkout -f "${current_pr_head}" &>/dev/null
else
echo "Cannot find test ${this_test}."
+ die 1
--- End diff --
thanks, nice catch. s/die/exit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
