itholic commented on a change in pull request #32779:
URL: https://github.com/apache/spark/pull/32779#discussion_r645295691
##########
File path: dev/reformat
##########
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
Review comment:
Also updated the PR description, thanks!
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -366,7 +366,7 @@ jobs:
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
- python3.6 -m pip install flake8 pydata_sphinx_theme mypy numpydoc
'jinja2<3.0.0'
+ python3.6 -m pip install flake8 pydata_sphinx_theme mypy numpydoc
'black==19.10b0' 'jinja2<3.0.0'
Review comment:
Upgrading the version changes the formatting as Hyukjin mentioned, but
they look better to read than the old code. (And it's not break the
`pycodestyle` as well)
I think it's good time to use the latest version of `black` now.
Let me remove the specified versions.
##########
File path: dev/requirements.txt
##########
@@ -32,3 +32,6 @@ sphinx-plotly-directive
# Development scripts
jira
PyGithub
+
+# pandas API on Spark Code formatter. Only support Python 3.6+
Review comment:
Maybe I think we don't need to specify the version anymore.
Or we should use the latest version now? e.g. `black==21.5b2`
##########
File path: dev/requirements.txt
##########
@@ -32,3 +32,6 @@ sphinx-plotly-directive
# Development scripts
jira
PyGithub
+
+# pandas API on Spark Code formatter. Only support Python 3.6+
Review comment:
Maybe I think we don't need to specify the version anymore.
Or we should use the latest version and changed the pinned version ? e.g.
`black==21.5b2`
##########
File path: dev/requirements.txt
##########
@@ -32,3 +32,6 @@ sphinx-plotly-directive
# Development scripts
jira
PyGithub
+
+# pandas API on Spark Code formatter. Only support Python 3.6+
Review comment:
Maybe I think we don't need to specify the version anymore.
Or we should use keep the pin with the upgraded version ? e.g.
`black==21.5b2`
##########
File path: dev/requirements.txt
##########
@@ -32,3 +32,6 @@ sphinx-plotly-directive
# Development scripts
jira
PyGithub
+
+# pandas API on Spark Code formatter. Only support Python 3.6+
Review comment:
Maybe I think we don't need to specify the version anymore.
Or should we keep the pin with the upgraded version ? e.g. `black==21.5b2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
