Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5827#discussion_r29510337
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -132,17 +174,30 @@ class SQLContext(@transient val sparkContext:
SparkContext)
protected[sql] lazy val optimizer: Optimizer = DefaultOptimizer
@transient
- protected[sql] val ddlParser = new DDLParser(sqlParser.parse(_))
+ protected[sql] val ddlParser = new DDLParser((sql: String) => {
getSQLDialect().parse(sql) })
@transient
- protected[sql] val sqlParser = {
- val fallback = new catalyst.SqlParser
- new SparkSQLParser(fallback.parse(_))
+ protected[sql] val sqlParser = new
SparkSQLParser(getSQLDialect().parse(_))
--- End diff --
I think we'd better keep it, not just for the mima test, but also for the
sub class of `Dialect`. e.g. we have to specify the `SparkSQLParser` for
`HiveQLDialect`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
