otterc commented on a change in pull request #32140:
URL: https://github.com/apache/spark/pull/32140#discussion_r645872258



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
##########
@@ -276,9 +342,13 @@ public void onComplete(String streamId) throws IOException 
{
     @Override
     public void onFailure(String streamId, Throwable cause) throws IOException 
{
       channel.close();

Review comment:
       I reverted back the code. We do want the same behavior, that is, to fail 
remaining blocks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to