viirya commented on pull request #32777: URL: https://github.com/apache/spark/pull/32777#issuecomment-855140795
IIRC, the original intention is to avoid the cost of virtual calls. If we are sure the performance isn't an issue anymore, deduplication of code is more welcome direction, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
