cloud-fan commented on a change in pull request #32513:
URL: https://github.com/apache/spark/pull/32513#discussion_r646327137
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
##########
@@ -227,9 +227,7 @@ class DataFrameCallbackSuite extends QueryTest
spark.range(10).select($"id", $"id").write.insertInto("tab")
Review comment:
can we change this test to trigger a runtime exception? e.g. the column
is int type and the input data is string type.
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -661,8 +662,10 @@ private[sql] class TestHiveSessionStateBuilder(
override def overrideConfs: Map[String, String] =
TestHiveContext.overrideConfs
- override def createQueryExecution: (LogicalPlan) => QueryExecution = { plan
=>
- new TestHiveQueryExecution(session.asInstanceOf[TestHiveSparkSession],
plan)
+ override def createQueryExecution:
+ (LogicalPlan, CommandExecutionMode.Value) => QueryExecution = {
Review comment:
ditto, indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
