dongjoon-hyun commented on a change in pull request #32802: URL: https://github.com/apache/spark/pull/32802#discussion_r646415383
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/TimestampWithoutTZType.scala ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.types + +import scala.math.Ordering +import scala.reflect.runtime.universe.typeTag + +import org.apache.spark.annotation.Unstable + +/** + * The timestamp without time zone type represents a local time in microsecond precision. + * It does not store or represent a time-zone. + * Its valid range is [0001-01-01T00:00:00.000000, 9999-12-31T23:59:59.999999]. + * + * Please use the singleton `DataTypes.TimestampWithoutTZType` to refer the type. + * @since 3.2.0 + */ +@Unstable +class TimestampWithoutTZType private() extends AtomicType { + /** + * Internally, a timestamp is stored as the number of microseconds from + * the epoch of 1970-01-01T00:00:00.000000(Unix system time zero) + */ + private[sql] type InternalType = Long + + @transient private[sql] lazy val tag = typeTag[InternalType] + + private[sql] val ordering = implicitly[Ordering[InternalType]] + + /** + * The default size of a value of the TimestampType is 8 bytes. Review comment: typo. `TimestampType` -> `TimestampWithoutTZType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
