cloud-fan commented on a change in pull request #32781:
URL: https://github.com/apache/spark/pull/32781#discussion_r647459794
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -92,6 +92,11 @@ case object REPARTITION extends ShuffleOrigin
// a certain partition number. Spark can't optimize it.
case object REPARTITION_WITH_NUM extends ShuffleOrigin
+// Indicates that the shuffle operator was added by the user-specified
repartition operator.
+// Spark first tries to coalesce partitions, if it cannot be coalesced, then
try to use the
+// local shuffle reader.
+case object REPARTITION_WITHOUT_COL_AND_NUM extends ShuffleOrigin
Review comment:
We can thing about the naming a bit more. e.g. `REPARTITION_WITH_COL`,
`REPARTITION_WITH_NUM`, `REPARTITION_WITH_NOTHING`
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -92,6 +92,11 @@ case object REPARTITION extends ShuffleOrigin
// a certain partition number. Spark can't optimize it.
case object REPARTITION_WITH_NUM extends ShuffleOrigin
+// Indicates that the shuffle operator was added by the user-specified
repartition operator.
+// Spark first tries to coalesce partitions, if it cannot be coalesced, then
try to use the
+// local shuffle reader.
+case object REPARTITION_WITHOUT_COL_AND_NUM extends ShuffleOrigin
Review comment:
We can think about the naming a bit more. e.g. `REPARTITION_WITH_COL`,
`REPARTITION_WITH_NUM`, `REPARTITION_WITH_NOTHING`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
