cloud-fan commented on a change in pull request #32513:
URL: https://github.com/apache/spark/pull/32513#discussion_r647524192
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala
##########
@@ -183,21 +183,21 @@ final class DataFrameWriterV2[T] private[sql](table:
String, ds: Dataset[T])
def overwritePartitions(): Unit = {
val dynamicOverwrite = OverwritePartitionsDynamic.byName(
UnresolvedRelation(tableName), logicalPlan, options.toMap)
- runCommand("overwritePartitions")(dynamicOverwrite)
+ runCommand()(dynamicOverwrite)
}
/**
* Wrap an action to track the QueryExecution and time cost, then report to
the user-registered
* callback functions.
*/
- private def runCommand(name: String)(command: LogicalPlan): Unit = {
+ private def runCommand()(command: LogicalPlan): Unit = {
Review comment:
nit: shall this just be `private def runCommand(command: LogicalPlan)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
